RFR: 1393: PR bot fails on missing .jcheck/conf [v10]

Zhao Song zsong at openjdk.org
Wed Nov 16 17:08:28 UTC 2022


On Wed, 16 Nov 2022 14:46:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated CommitCommandTests#missingJcheckConf
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 227:
> 
>> 225:         var seedPath = bot.seedStorage().orElse(scratchPath.resolve("seeds"));
>> 226:         var hostedRepositoryPool = new HostedRepositoryPool(seedPath);
>> 227:         CensusInstance census = null;
> 
> I don't think you need to assign null here as all exception paths will return.

Got it, I will change it.

-------------

PR: https://git.openjdk.org/skara/pull/1407


More information about the skara-dev mailing list