RFR: 1393: PR bot fails on missing .jcheck/conf [v10]

[Zhao Song]

On Wed, 16 Nov 2022 14:41:32 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated CommitCommandTests#missingJcheckConf
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 241:
> 
>> 239:                 addErrorComment(text, comments);
>> 240:             } else {
>> 241:                 log.info("No .jcheck/conf found in external repo " + bot.confOverrideRepository().get().name() + ": " + e);
> 
> The file isn't necessarily called `.jcheck/conf`, the name is given in `bot.confOverrideName()`.
> 
> The log should be at SEVERE level and the throwable should be included. To achieve this, you need to use the `log` method. By making it SEVERE, we will get admin notifications about this.
> 
> Suggestion:
> 
>                 log.log(Level.SEVERE, "Jcheck configuration file " + bot.confOverrideName() + " not found in external repo " + bot.confOverrideRepository().get().name(), e);

You are right! This one looks better!

-------------

PR: https://git.openjdk.org/skara/pull/1407