RFR: 1679: Make username and prefix optional config options for slack log handler

Kevin Rushforth kcr at openjdk.org
Wed Nov 16 21:14:59 UTC 2022


On Wed, 16 Nov 2022 20:43:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> In [SKARA-1660](https://bugs.openjdk.org/browse/SKARA-1660) I added the new "prefix" config option for the slack log handler. This will be used instead of the username field. The problem is that neither field was made optional in the config parser, so now we have to configure both, regardless of if we want them or not. The actual handler logic treats them as optional, but the config parser throws NPE.
> 
> This patch adds null checks to avoid the NPEs.

Marked as reviewed by kcr (Reviewer).

-------------

PR: https://git.openjdk.org/skara/pull/1421


More information about the skara-dev mailing list