Integrated: 1679: Make username and prefix optional config options for slack log handler

Erik Joelsson erikj at openjdk.org
Wed Nov 16 21:17:39 UTC 2022


On Wed, 16 Nov 2022 20:43:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> In [SKARA-1660](https://bugs.openjdk.org/browse/SKARA-1660) I added the new "prefix" config option for the slack log handler. This will be used instead of the username field. The problem is that neither field was made optional in the config parser, so now we have to configure both, regardless of if we want them or not. The actual handler logic treats them as optional, but the config parser throws NPE.
> 
> This patch adds null checks to avoid the NPEs.

This pull request has now been integrated.

Changeset: 7e0a1581
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/7e0a15810a8679a4d8fe7e9f9959dfe3a7d949be
Stats:     11 lines in 1 file changed: 3 ins; 0 del; 8 mod

1679: Make username and prefix optional config options for slack log handler

Reviewed-by: kcr

-------------

PR: https://git.openjdk.org/skara/pull/1421


More information about the skara-dev mailing list