RFR: 1686: Warning message for backport mistakes is not clear [v2]
Zhao Song
zsong at openjdk.org
Tue Nov 22 20:58:54 UTC 2022
> A user reported that he found many PR with "issue is not open" warning. After discussing in slack, we found that this happens because backport-style PR wasn't used.
>
> To improve the experience of user, we need to give some useful information to the user instead of just telling them "Issue is not open".
>
> In this patch, when a user is trying to create a PR related with a resolved issue, we will assume that the user wants to create a backport PR but in the wrong way. So in this case, we will tell the user how to create a correct backport pr. In other case, for example, the issue is closed with "Not an Issue", we will still just tell the user "Issue is not open".
Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
- Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1425/files
- new: https://git.openjdk.org/skara/pull/1425/files/86c18f61..482018a9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1425&range=01
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1425&range=00-01
Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/skara/pull/1425.diff
Fetch: git fetch https://git.openjdk.org/skara pull/1425/head:pull/1425
PR: https://git.openjdk.org/skara/pull/1425
More information about the skara-dev
mailing list