RFR: 1686: Warning message for backport mistakes is not clear [v2]

[Zhao Song]

On Tue, 22 Nov 2022 19:59:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 644:
> 
>> 642:                                         (issueType == null || !List.of("CSR", "JEP").contains(issueType.asString()))) {
>> 643:                                     if (iss.get().isFixed()) {
>> 644:                                         progressBody.append("⚠️ " + iss.get().id() + " is already resolved. " +
> 
> No need to print the ID here, it's already present first on the line. Also, it looks like you are missing a space before the warning emoji.
> Suggestion:
> 
>                                         progressBody.append(" ⚠️ Issue is already resolved. " +

yes, missed a space again

-------------

PR: https://git.openjdk.org/skara/pull/1425