RFR: 1683: The force push notifier needs an overhaul [v5]

Zhao Song zsong at openjdk.org
Wed Nov 23 20:03:20 UTC 2022

> A user reported a bug related with the force-push notification. Erik investigated it and found the implementation of this notification should not be in the `PullRequestBranchNotifier`. Also, users preferred to not get force-push notification if the force-push happens when the pr is in draft state.
> In this patch, the implementation of checking force-push and notifying user are moved to `CheckWorkItem`. Also, force-pushing or rebasing a draft pr will not warn user any more.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  adjust comment


  - all: https://git.openjdk.org/skara/pull/1426/files
  - new: https://git.openjdk.org/skara/pull/1426/files/2787b7b5..5037bea6

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1426&range=04
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1426&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1426.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1426/head:pull/1426

PR: https://git.openjdk.org/skara/pull/1426

More information about the skara-dev mailing list