RFR: 1683: The force push notifier needs an overhaul [v4]
Zhao Song
zsong at openjdk.org
Wed Nov 23 20:00:13 UTC 2022
On Wed, 23 Nov 2022 19:44:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into SKARA-1683
>>
>> # Conflicts:
>> # bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
>> - adjust comment
>> - fix some bugs
>> - delete two blank lines
>> - SKARA-1683
>
> forge/src/main/java/org/openjdk/skara/forge/PullRequest.java line 186:
>
>> 184: * Return the last time something was force pushed while not in draft state.
>> 185: * If there is no force-push in pull request
>> 186: * or the restful api doesn't support force-push, return empty.
>
> While this is strictly less than 80, we also like to keep the lines even. I'm not sure if Intellij has any automation for this. I've just capitulated to doing it manually.
I also don't know whether IntelliJ can do this. I will do it manually.
-------------
PR: https://git.openjdk.org/skara/pull/1426
More information about the skara-dev
mailing list