RFR: 1690: Make jcheck cli able to use conf from workspace or other commit

Erik Joelsson erikj at openjdk.org
Wed Nov 30 00:02:27 UTC 2022

On Tue, 29 Nov 2022 22:43:38 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> It case 5 really worth the complexity? The `--working-tree` option is equivalent to `--conf-file .jcheck/conf`. As for `--staged`, I can imagine that it might be an occasionally useful "nice to have", but how often will developers really want to run `jcheck` against the version of `.jcheck/conf` in the index?

The idea with 5 is that the user won't have to commit before performing a whitespace check. I find it rather cumbersome to have to commit before I can verify jcheck.

I agree that `--conf-working-tree` is equivalent to `--conf-file .jcheck/conf` so we don't really need it. OTOH, I figured it would be pretty simple to implement.


PR: https://git.openjdk.org/skara/pull/1428

More information about the skara-dev mailing list