RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v4]
Zhao Song
zsong at openjdk.org
Wed Nov 30 23:59:45 UTC 2022
> Currently, the command `git skara jcheck` can only use the `.jcheck/conf` configuration file in the current checking commit.
> However, sometimes users want to run jcheck with different configurations to validate their commits. Therefore, we need to upgrade `git skara jcheck`.
>
> In this patch, `git skara jcheck` would be able to support following usecases.
>
> 1. Run jcheck on a commit or a series of commits using the .jcheck/conf in the same commit. (what we do by default today)
> `git skara jcheck`
>
> 2. Run jcheck on a commit or a series of commits using the .jcheck/conf in a different specified commit.
> `git skara jcheck --specified-conf-commit <COMMIT HASH>`
>
> 3. Run jcheck on a commit or a series of commits using the .jcheck/conf in my workspace.
> `git skara jcheck --workspace-conf`
>
> 4. Run jcheck on a commit or a series of commits using a config file that I point to directly, that may have any name.
> `git skara jcheck --workspace-conf --conf-file <FILENAME>`
>
> 5. Run jcheck on the diff in my current workspace, either --staged or not using the .jcheck/conf in my workspace.
> `git skara jcheck --workspace-diff`
Zhao Song has updated the pull request incrementally with four additional commits since the last revision:
- Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1428/files
- new: https://git.openjdk.org/skara/pull/1428/files/5c5ce30c..3d2606a5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1428&range=03
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1428&range=02-03
Stats: 6 lines in 1 file changed: 0 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/skara/pull/1428.diff
Fetch: git fetch https://git.openjdk.org/skara pull/1428/head:pull/1428
PR: https://git.openjdk.org/skara/pull/1428
More information about the skara-dev
mailing list