RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v3]

Zhao Song zsong at openjdk.org
Wed Nov 30 23:59:46 UTC 2022


On Wed, 30 Nov 2022 23:04:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   implemented case 5
>
> cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 243:
> 
>> 241: 
>> 242:         var staged = arguments.contains("staged");
>> 243:         var working_tree = arguments.contains("working-tree");
> 
> Please use camelCase for local variables.
> Suggestion:
> 
>         var workingTree = arguments.contains("working-tree");

Will change it

-------------

PR: https://git.openjdk.org/skara/pull/1428


More information about the skara-dev mailing list