RFR: 1563: The method 'CheckRun#updateMergeReadyComment' shouldn't update the comment if the comment has not changed [v3]
Erik Joelsson
erikj at openjdk.org
Tue Oct 4 13:53:23 UTC 2022
On Fri, 30 Sep 2022 19:05:29 GMT, Zhao Song <duke at openjdk.org> wrote:
>> Do not update comment if the comment already exists.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> dummy commit to see whether the macOS test fail is occasional
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 938:
> 936: pr.updateComment(existing.get().id(), message);
> 937: } else {
> 938: log.info("Merge ready comment already exists, no need to update the comment");
Suggestion:
log.info("Merge ready comment already exists, no need to update");
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 947:
> 945: pr.updateComment(existing.get().id(), message);
> 946: } else {
> 947: log.info("No longer ready comment already exists, no need to update the comment");
Suggestion:
log.info("No longer ready comment already exists, no need to update");
-------------
PR: https://git.openjdk.org/skara/pull/1386
More information about the skara-dev
mailing list