RFR: 1452: Can never notify on first commit [v2]

[Erik Joelsson]

On Tue, 4 Oct 2022 22:54:16 GMT, Zhao Song <zsong at openjdk.org> wrote:

> I want to confirm whether I understand you correctly.
> 
> Case1: Completely new repo or repo with few commits In this situation, we should let the notify bot make notifications on the **first** commit and make notifications on every new commit.
> 
> Case2: Repo with a long history In this situation, we should let the notify bot **not** make notifications on the **first** commit and make notifications on every new commit.
> 
> And currently, My solution will let the notify bot make notifications on the first commit whether the repo is new or the repo has a long history, so I should fix it.

I think you got it right, but I want to clarify a little bit more.

Case1: Notify on every commit, starting from the very first in each branch that should be notified on.
Case2: Mark the currently existing HEAD in each branch as already notified and then continue notifying from there for any new commit that appears.

I would suggest a default threshold of 5 existing commits to trigger case1 (either define a constant for it or maybe introduce a configuration parameter).

-------------

PR: https://git.openjdk.org/skara/pull/1385