RFR: 1215: Clean label not updating correctly

Erik Joelsson erikj at openjdk.org
Tue Oct 4 17:36:28 UTC 2022

On Tue, 4 Oct 2022 17:27:38 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>>> I think the new comment should trigger a metadata change.
>> Do you mean the commit message? Yeah, if we change the commit message it will trigger a metadata change. So in this situation, the commit message will always be changed, right?
> I see now that it doesn't. I need to think about this.

Ah, the problem is that `<!-- backport` is not matched as a metadata comment in `CheckWorkItem::getMetadata`. See the regexp `metadataComments`. If you add that, it should consider the backport hash comments as updates that need rechecking.


PR: https://git.openjdk.org/skara/pull/1388

More information about the skara-dev mailing list