RFR: 1215: Clean label not updating correctly

Zhao Song duke at openjdk.org
Tue Oct 4 17:45:10 UTC 2022


On Tue, 4 Oct 2022 17:33:05 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Ah, the problem is that `<!-- backport` is not matched as a metadata comment in `CheckWorkItem::getMetadata`. See the regexp `metadataComments`. If you add that, it should consider the backport hash comments as updates that need rechecking.

Yes, but I also wonder whether the comment author is the same as the pr user, otherwise the comment will be filtered out `.filter(comment -> comment.author().id().equals(pr.repository().forge().currentUser().id()))`

-------------

PR: https://git.openjdk.org/skara/pull/1388


More information about the skara-dev mailing list