RFR: 1618: CSR bot failed to update PR when CSR was approved
gli at openjdk.org
Thu Oct 6 05:22:06 UTC 2022
On Wed, 5 Oct 2022 16:49:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> This patch fixes a mistake in the CSRBotFactory. The intention was to create one CSRIssueBot for each unique IssueProject, but we currently get one per repository instead. This is because JiraProject doesn't implement hashcode, so we can't trust a HashSet to sort out uniqueness. I'm changing this to a HashMap and using the configuration string as key instead.
> For details on how this was causing the reported problem, see comments in the bug.
This patch reduces the duplicated bots and maps one issue bot to one IssueProject. It also solves the SKARA-1618 as a side effect.
But I don't think it is the root cause of SKARA-1618. The `IssueWorkItem#concurrentWith` currently only checks the issue project's name and doesn't check the issue id and repos' names so that these work items can't be run concurrently and some of them will be eliminated (Because the method `WorkItem#replaces` returns `true`).
So I suggest to file another issue to record this patch and solve SKARA-1618 by revising the method `IssueWorkItem#concurrentWith` in another patch. What is your opinion?
More information about the skara-dev