RFR: 1618: CSR bot failed to update PR when CSR was approved

Erik Joelsson erikj at openjdk.org
Thu Oct 6 17:14:22 UTC 2022

On Thu, 6 Oct 2022 05:18:18 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> But I don't think it is the root cause of SKARA-1618. The `IssueWorkItem#concurrentWith` currently only checks the issue project's name and doesn't check the issue id and repos' names so that these work items can't be run concurrently and some of them will be eliminated (Because the method `WorkItem#replaces` returns `true`).
> So I suggest to file another issue to record this patch and solve SKARA-1618 by revising the method `IssueWorkItem#concurrentWith` in another patch. What is your opinion?

Good catch that the concurrentWith method is also wrong. I don't think there is any point in splitting the fixes though, I will fix that method in this change.


PR: https://git.openjdk.org/skara/pull/1391

More information about the skara-dev mailing list