RFR: 1618: CSR bot failed to update PR when CSR was approved [v2]

Erik Joelsson erikj at openjdk.org
Thu Oct 6 17:25:28 UTC 2022

> This patch fixes a mistake in the CSRBotFactory. The intention was to create one CSRIssueBot for each unique IssueProject, but we currently get one per repository instead. This is because JiraProject doesn't implement hashcode, so we can't trust a HashSet to sort out uniqueness. I'm changing this to a HashMap and using the configuration string as key instead.
> For details on how this was causing the reported problem, see comments in the bug.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Fix IssueWorkItem::concurrentWith


  - all: https://git.openjdk.org/skara/pull/1391/files
  - new: https://git.openjdk.org/skara/pull/1391/files/933dec3a..eef733fa

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1391&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1391&range=00-01

  Stats: 16 lines in 1 file changed: 15 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1391.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1391/head:pull/1391

PR: https://git.openjdk.org/skara/pull/1391

More information about the skara-dev mailing list