RFR: 1452: Can never notify on first commit [v3]

Zhao Song zsong at openjdk.org
Thu Oct 6 18:44:17 UTC 2022

On Thu, 6 Oct 2022 17:48:30 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   set a threshold to determine whether should notify on first commit
> vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java line 1500:
>> 1498:     @Override
>> 1499:     public int getExistingCommits() throws IOException {
>> 1500:         //TODO:: implement it later, return 10 here so that it will maintain the previous behavior
> Should probably throw `UnsupportedOperationException` if not implementing this. I know we aren't using this for any HG repos in production. Is there any test that would trip this?
> You could also implement it. A reasonable command line would be
> hg id --num --rev tip
> and then add 1 to that number, because the first commit in HG is numbered 0.

I don't think we would create any HG repo in tests, so no test will trip this. 
I am not familiar with HG repo, so I didn't implement it.
I will use the command you mentioned to implement it. Thanks!


PR: https://git.openjdk.org/skara/pull/1385

More information about the skara-dev mailing list