RFR: 1452: Can never notify on first commit [v3]
Zhao Song
zsong at openjdk.org
Thu Oct 6 18:47:40 UTC 2022
On Thu, 6 Oct 2022 17:49:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> set a threshold to determine whether should notify on first commit
>
> vcs/src/main/java/org/openjdk/skara/vcs/Repository.java line 301:
>
>> 299: }
>> 300:
>> 301: int getExistingCommits() throws IOException;
>
> Suggestion:
>
> int commitCount() throws IOException;
>
> Also, this should be moved to `ReadOnlyRepository` as it's a pure read operation.
yes, it's much better!
-------------
PR: https://git.openjdk.org/skara/pull/1385
More information about the skara-dev
mailing list