RFR: 1626: 8-pool records not consumed by openjdk8uX fixversions
ehelin at openjdk.org
Fri Oct 7 12:21:13 UTC 2022
On Tue, 4 Oct 2022 19:58:33 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> The logic for matching *-pool records in backports is not matching openjdk8uX to an issue with fixVersion 8-pool. The version parsing logic for OpenJDK releases is a bit of a minefield, where sometimes the prefix is relevant and sometimes not. This fix isolates ignoring of the prefix to just matching of *-pool records in Backports.java. I'm reusing the same regex that already existed for doing something similar in that class. The previous usage was in the logic for the hgupdate-sync label.
> I don't think this will introduce any unwanted behavior, but I would appreciate if someone else could help think it through.
> I chose to prioritize exact *-pool matches and fallback to matching just the numeric part of the feature version. This means that if we decided to add openjdk8-pool as a pool version in the future, that would continue to work.
Marked as reviewed by ehelin (Reviewer).
Yeah, this is a minefield 😨 I can't say that your change is obviously correct, but at least the existing tests and your new test is passing and the newly added logic corresponds to your reasoning. But whether that is the end of OpenJDK version parsing is hard to say 🤷
More information about the skara-dev