Integrated: 1626: 8-pool records not consumed by openjdk8uX fixversions

Erik Joelsson erikj at openjdk.org
Fri Oct 7 20:02:45 UTC 2022


On Tue, 4 Oct 2022 19:58:33 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The logic for matching *-pool records in backports is not matching openjdk8uX to an issue with fixVersion 8-pool. The version parsing logic for OpenJDK releases is a bit of a minefield, where sometimes the prefix is relevant and sometimes not. This fix isolates ignoring of the prefix to just matching of *-pool records in Backports.java. I'm reusing the same regex that already existed for doing something similar in that class. The previous usage was in the logic for the hgupdate-sync label.
> 
> I don't think this will introduce any unwanted behavior, but I would appreciate if someone else could help think it through.
> 
> I chose to prioritize exact *-pool matches and fallback to matching just the numeric part of the feature version. This means that if we decided to add openjdk8-pool as a pool version in the future, that would continue to work.

This pull request has now been integrated.

Changeset: 68b4f587
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/68b4f58708ef4c113a81ce38455192a692f4c86b
Stats:     28 lines in 2 files changed: 23 ins; 2 del; 3 mod

1626: 8-pool records not consumed by openjdk8uX fixversions

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.org/skara/pull/1389


More information about the skara-dev mailing list