RFR: 1618: CSR bot failed to update PR when CSR was approved [v2]

Erik Helin ehelin at openjdk.org
Fri Oct 7 12:21:25 UTC 2022

On Thu, 6 Oct 2022 17:25:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> This patch fixes a mistake in the CSRBotFactory. The intention was to create one CSRIssueBot for each unique IssueProject, but we currently get one per repository instead. This is because JiraProject doesn't implement hashcode, so we can't trust a HashSet to sort out uniqueness. I'm changing this to a HashMap and using the configuration string as key instead.
>> For details on how this was causing the reported problem, see comments in the bug.
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>   Fix IssueWorkItem::concurrentWith

Looks good


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.org/skara/pull/1391

More information about the skara-dev mailing list