Integrated: 1618: CSR bot failed to update PR when CSR was approved

Erik Joelsson erikj at openjdk.org
Fri Oct 7 20:05:53 UTC 2022


On Wed, 5 Oct 2022 16:49:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch fixes a mistake in the CSRBotFactory. The intention was to create one CSRIssueBot for each unique IssueProject, but we currently get one per repository instead. This is because JiraProject doesn't implement hashcode, so we can't trust a HashSet to sort out uniqueness. I'm changing this to a HashMap and using the configuration string as key instead.
> 
> For details on how this was causing the reported problem, see comments in the bug.

This pull request has now been integrated.

Changeset: 55084b1b
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/55084b1bc6ff1d1d3261c19347a6eb3ec120104d
Stats:     25 lines in 2 files changed: 19 ins; 1 del; 5 mod

1618: CSR bot failed to update PR when CSR was approved

Reviewed-by: gli, ehelin

-------------

PR: https://git.openjdk.org/skara/pull/1391


More information about the skara-dev mailing list