RFR: 1452: Can never notify on first commit [v8]

[Erik Joelsson]

On Fri, 7 Oct 2022 16:34:32 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   A better way to represent NULL_REVISION
>
> vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java line 173:
> 
>> 171:     int commitCount() throws IOException;
>> 172: 
>> 173:     Hash initialHash();
> 
> Since the initial hash is called differently in Git Repo and Hg Repo,  I named the method initialHash. I don't know if this is appropriate.

I think the name is ok. I suggest adding a comment describing what it is though.
Suggestion:

    /**
     * Returns the special hash that references the virtual commit before the first real commit in a repository.
     */
    Hash initialHash();

-------------

PR: https://git.openjdk.org/skara/pull/1385