RFR: 1625: Validate input from /summary command [v3]

[Erik Joelsson]

On Mon, 24 Oct 2022 17:32:54 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 158:
>> 
>>> 156:     public void visit(InvalidReviewersIssue e) {
>>> 157:         var invalid = String.join(", ", e.invalid());
>>> 158:         throw new BadCommitMessageException("Invalid reviewers " + invalid);
>> 
>> I didn't mean for this new exception to be used everywhere. We were specifically trying to avoid just issues with the commit message here.
>
>> I didn't mean for this new exception to be used everywhere. We were specifically trying to avoid just issues with the commit message here.
> 
> I was thinking about whether to change the exception type here. In my opinion, if one of the reviewers is invalid, it is meaningless for the bot to retry, we also should make the bot end.

Hm, you are probably right there, it was just that the specific exception name didn't fit here. But, if we report failures in the normal way instead, it's all good.

-------------

PR: https://git.openjdk.org/skara/pull/1401