RFR: 1625: Validate input from /summary command [v3]

Zhao Song zsong at openjdk.org
Mon Oct 24 17:53:14 UTC 2022

On Mon, 24 Oct 2022 17:28:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Looking more at this, communicating through an exception seems wrong. The visitor already has a way to communicate problems through the addFailureMessage method. We should just stop throwing exception and treat this as any other "normal" failure.

Yes, this way is better. I was just trying to make bad commit message as an `integrationBlocker`. If we choose the way you mentioned, we also no longer need the `BadCommitMessageException`, right?


PR: https://git.openjdk.org/skara/pull/1401

More information about the skara-dev mailing list