RFR: 1568: Dependency PR Resolution Detection Does Not Check Means of Resolution

Erik Joelsson erikj at openjdk.org
Fri Sep 2 13:54:37 UTC 2022

On Thu, 1 Sep 2022 05:29:35 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> Currently, the closed but not integrated PR causes the dependent PRs to be retargeted. It is not right. This patch fixes it and changes the test case.
> Thanks for taking the time to review.
> Best Regards,
> -- Guoxiong

I don't think this really solves the issue. The pr branch for the closed PR is still deleted, so the dependent PR will still get retargeted, but without any notification to the user. I think we need to post a different message in the dependent PRs, explaining that the PR this PR depends on was closed without being integrated.

Reading the current message, the word 'dependent' isn't used correctly.


PR: https://git.openjdk.org/skara/pull/1365

More information about the skara-dev mailing list