RFR: 1568: Dependency PR Resolution Detection Does Not Check Means of Resolution

Guoxiong Li gli at openjdk.org
Fri Sep 2 20:24:28 UTC 2022

On Fri, 2 Sep 2022 13:51:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I don't think this really solves the issue. The pr branch for the closed PR is still deleted, so the dependent PR will still get retargeted, but without any notification to the user.

I agree that this patch needs to be adjusted. At least the branch can't be deleted before the successor pull request retargeting and notifing.

> I think we need to post a different message in the dependent PRs, explaining that the PR this PR depends on was closed without being integrated.

Posting another message is an available way. But it can't actually solve all the problem. There are several situations we may meet (some but not all):

- The dependent pull request is closed because of timeout.

At this situation, we may need the author to re-open the pull request and continue the work. And target branch of the successor pull request should be adjusted to this dependent pull request again.

- The dependent pull request is closed intendedly because the author want the change to be implemented in the successor pull request (two patch reduce to one patch).

At this situation, the bot only need to retarget the branch, just like your suggestion.

-  The dependent pull request is closed because the another better pull request is submitted.

At this situation, the bot now don't know which branch the successor pull request should retarget to.

- The dependent pull request is closed because its feature is no longer needed.

At this situation, we don't know the succesor pull request how to change.

The bot can't handle all the situations even though we can list all the situations. There may be two root reasons:
1. The bot or we (the developers of the bot) don't know why the pull request is closed in some situations. It is complicated.
2. The bot currently doesn't have the ability to retarget the branch to the original branch (But this can be implemented).


PR: https://git.openjdk.org/skara/pull/1365

More information about the skara-dev mailing list