RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v2]

Guoxiong Li gli at openjdk.org
Fri Sep 2 14:40:42 UTC 2022

On Wed, 31 Aug 2022 13:50:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with five additional commits since the last revision:
>>  - Fix some comments and messages the bot replies.
>>  - Refactor to remove the redundant expressions.
>>  - Remove the redundant scheduling log info.
>>  - Fix the decription in ApprovalCommand.
>>  - Rename the methods and fields about 'update change' and fix related comments.
> bots/approval/src/main/java/org/openjdk/skara/bots/approval/ApprovalPullRequestWorkItem.java line 86:
>> 84:     private boolean hasApprovalProgress(PullRequest pr) {
>> 85:         var statusMessage = getStatusMessage(pr);
>> 86:         return statusMessage.contains("- [ ] Change must be properly approved by the maintainers") ||
> This string is repeated a lot. We really need to centralize it at least within this class. I have filed SKARA-1547 for moving PR constants to a single central location, so I'm ok with one copy per bot for now, but if you want to introduce a `PullRequestConstants` class in the forge module right now and put your new constants there, that would be ok too.
> On the other hand, I don't think we need this particular string in this bot.

I would like to let the SKARA-1547 to solve this problem.


PR: https://git.openjdk.org/skara/pull/1364

More information about the skara-dev mailing list