RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v2]

[Guoxiong Li]

On Fri, 2 Sep 2022 14:37:25 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/approval/src/main/java/org/openjdk/skara/bots/approval/ApprovalPullRequestWorkItem.java line 86:
>> 
>>> 84:     private boolean hasApprovalProgress(PullRequest pr) {
>>> 85:         var statusMessage = getStatusMessage(pr);
>>> 86:         return statusMessage.contains("- [ ] Change must be properly approved by the maintainers") ||
>> 
>> This string is repeated a lot. We really need to centralize it at least within this class. I have filed SKARA-1547 for moving PR constants to a single central location, so I'm ok with one copy per bot for now, but if you want to introduce a `PullRequestConstants` class in the forge module right now and put your new constants there, that would be ok too.
>> 
>> On the other hand, I don't think we need this particular string in this bot.
>
> I would like to let the SKARA-1547 to solve this problem.

> On the other hand, I don't think we need this particular string in this bot.

What does it mean? Could you explain it in detailed?

-------------

PR: https://git.openjdk.org/skara/pull/1364