RFR: 1568: Dependency PR Resolution Detection Does Not Check Means of Resolution [v2]

[Erik Joelsson]

On Wed, 7 Sep 2022 10:22:29 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> Currently, the closed but not integrated PR causes the dependent PRs to be retargeted. It is not right. This patch fixes it and changes the test case.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add another comment about not integrated pull request.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/prbranch/PullRequestBranchNotifier.java line 121:

> 119:                             request to be updated, which means that changes from the parent pull request will start to show up \
> 120:                             in this pull request. If closing the parent pull request was done in error, it will need to be \
> 121:                             re-opened and this pull request will need to be retargeted again manually.

Reading what I wrote again, I want to revise it a bit.
Suggestion:

                            The parent pull request that this pull request depends on has been closed without being \ 
                            integrated and the target branch of this pull request has been updated as the previous \
                            branch was deleted. This means that changes from the parent pull request will start to \
                            show up in this pull request. If closing the parent pull request was done in error, it will \
                            need to be re-opened and this pull request will need to manually be retargeted again.

-------------

PR: https://git.openjdk.org/skara/pull/1365