RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v6]

[Magnus Ihse Bursie]

On Fri, 2 Sep 2022 14:23:26 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java line 109:
>> 
>>> 107:         }
>>> 108: 
>>> 109:         pr.setState(Issue.State.OPEN);
>> 
>> Why change the state of the PR?
>
> The pull request would be automatically closed by the bot if the maintainer had rejected the pull request before. And at second thought, the maintainer approves the pull request, we need to open it to confirm the CheckWorkItem can be re-run in this pull request.
> 
> But now I find a bug about opening/closing the pull request automatically. When the maintainer has rejected the pull request, the pull request was closed by the bot. But if the author of the pull request re-open the pull request by using the `open` command (the author may want to change the pull request), the bot will re-close the pull request again because the disapproval label still exists. This bug seems not easy to solve now, so I suggest that the bot doesn't set the pull request state automatically. What is your opinion.

Let the user close the PR themselves.

-------------

PR: https://git.openjdk.org/skara/pull/1364