RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v6]
Guoxiong Li
gli at openjdk.org
Thu Sep 22 09:09:54 UTC 2022
On Wed, 21 Sep 2022 10:21:56 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix tests.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java line 129:
>
>> 127: });
>> 128: }
>> 129: if (pr.labelNames().contains("approval")) {
>
> Also, the label should probably be `approved`, since we use adjectives (like `ready`) for labels.
I read the [labels](https://github.com/openjdk/jdk/labels) of the JDK project. Almost all of them are nouns and only few labels are adjectives. And the `approved` may be misunderstood as `the pull request has been approved`. So I use the label `approval`.
-------------
PR: https://git.openjdk.org/skara/pull/1364
More information about the skara-dev
mailing list