RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v6]

Erik Joelsson erikj at openjdk.org
Thu Sep 22 16:48:00 UTC 2022

On Thu, 22 Sep 2022 09:07:11 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java line 129:
>>> 127:             });
>>> 128:         }
>>> 129:         if (pr.labelNames().contains("approval")) {
>> Also, the label should probably be `approved`, since we use adjectives (like `ready`) for labels.
> I read the [labels](https://github.com/openjdk/jdk/labels) of the JDK project. Almost all of them are nouns and only few labels are adjectives. And the `approved` may be misunderstood as `the pull request has been approved`. So I use the label `approval`.

I agree, the `approval` label is meant to signal that this PR is waiting on/needs approval.


PR: https://git.openjdk.org/skara/pull/1364

More information about the skara-dev mailing list