RFR: 327: git webrev: Print the location of the generated webrev upon successful completion

Erik Joelsson erikj at openjdk.org
Fri Sep 23 14:38:27 UTC 2022

On Thu, 22 Sep 2022 16:04:44 GMT, Zhao Song <duke at openjdk.org> wrote:

> Originally, git webrev command would return nothing when executed successfully. It is not a good experience for user. 
> Right now, when executed successfully, the location of index.html will be printed.
> Also, added a --quiet flag if the current silent behavior is required.

cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java line 463:

> 461:         if (!quiet) {
> 462:             System.out.println("Webrev executed successfully, details are in the link below:");
> 463:             System.out.println("file://" + new File(output.resolve("index.html").toUri()).getAbsoluteFile());

That looks like a weird way to generate a URL. Why not just:



PR: https://git.openjdk.org/skara/pull/1379

More information about the skara-dev mailing list