RFR: 327: git webrev: Print the location of the generated webrev upon successful completion [v2]

Zhao Song duke at openjdk.org
Fri Sep 23 16:40:23 UTC 2022


On Fri, 23 Sep 2022 14:35:04 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   optimize the way to generate a URL
>
> cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java line 463:
> 
>> 461:         if (!quiet) {
>> 462:             System.out.println("Webrev executed successfully, details are in the link below:");
>> 463:             System.out.println("file://" + new File(output.resolve("index.html").toUri()).getAbsoluteFile());
> 
> That looks like a weird way to generate a URL. Why not just:
> Suggestion:
> 
>             System.out.println(output.resolve("index.html").toUri());

Yeah, will do the change

-------------

PR: https://git.openjdk.org/skara/pull/1379


More information about the skara-dev mailing list