RFR: 1364: Jira Issues should be resolved as "Fixed" [v2]

[Erik Joelsson]

On Fri, 23 Sep 2022 18:28:14 GMT, Zhao Song <duke at openjdk.org> wrote:

>> Jira Issues will be resolved as "Fixed" regardless of the current state.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check the resolution of JiraIssue before setting the state to Resolved

bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 198:

> 196:                     log.info("Resolving issue which status is not open, the status is " + issue.state());
> 197:                 } else {
> 198:                     log.info("Resolving issue " + issue.id());

No need for conditional here, we can use the same log message regardless of current state. Also, updating assignees should also be done (as long as it's currently empty).
Suggestion:

                log.info("Resolving issue " + issue.id() + " from state " + issue.state());

bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 210:

> 208:                     issue.setState(Issue.State.RESOLVED);
> 209:                 } else {
> 210:                     log.info("The issue has been already resolved");

Suggestion:

                    log.info("The issue was already 'fixed'");

Same below.

-------------

PR: https://git.openjdk.org/skara/pull/1382