RFR: 1364: Jira Issues should be resolved as "Fixed" [v2]

Zhao Song duke at openjdk.org
Fri Sep 23 19:26:15 UTC 2022

On Fri, 23 Sep 2022 18:28:14 GMT, Zhao Song <duke at openjdk.org> wrote:

>> Jira Issues will be resolved as "Fixed" regardless of the current state.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   Check the resolution of JiraIssue before setting the state to Resolved

bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 320:

> 318:                     issue.addComment(commitNotification);
> 319:                 }
> 320:                 if (issue.state() != Issue.State.OPEN) {

Hi @erikj79 , I am wondering whether we need condition here. Do we only update the assignee when the issue is open?


PR: https://git.openjdk.org/skara/pull/1382

More information about the skara-dev mailing list