RFR: 1858: Make it possible to configure to require reviewers for "Merge" PRs [v3]

Zhao Song zsong at openjdk.org
Tue Apr 4 15:29:47 UTC 2023

On Tue, 4 Apr 2023 13:24:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>   SKARA-1858
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 119:
>> 117:             var repository = configuration.repository(repo.name());
>> 118:             var botBuilder = PullRequestBot.newBuilder()
>> 119:                                            .repo(configuration.repository(repo.name()))
> Why this change? The variable repository is defined on the line above.

When merging SKARA-1850 to this one, I must made a mistake. Thanks for catching it!


PR Review Comment: https://git.openjdk.org/skara/pull/1495#discussion_r1157427061

More information about the skara-dev mailing list