RFR: 1858: Make it possible to configure to require reviewers for "Merge" PRs [v3]

Zhao Song zsong at openjdk.org
Tue Apr 4 15:34:04 UTC 2023

On Tue, 4 Apr 2023 13:27:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>   SKARA-1858
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java line 211:
>> 209: 
>> 210:             // Author and committer should updated in the merge commit
>> 211:             var headCommit = pushedRepo.commits(headHash.hex() + "^.." + headHash.hex()).asList().get(0);
> Does the commit message contain a "Reviewed-by" line?

Yes, it should have. I will update the test. Thx


PR Review Comment: https://git.openjdk.org/skara/pull/1495#discussion_r1157432646

More information about the skara-dev mailing list