RFR: 1878: Improve argument check in SKARA CLI [v2]

Zhao Song zsong at openjdk.org
Fri Apr 14 16:14:46 UTC 2023

> Currently, if a user misuses a command, in some cases, SKARA CLI crashes and throws a stack trace, which is bad and does not provide useful information to the user. 
> After investigating, I found that in many places, we don't check whether an option is followed by an argument, and it would trigger some issues.
> In this patch, the program would always check the presence of an argument  before attempting to retrieve it for an option.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  update copyright


  - all: https://git.openjdk.org/skara/pull/1502/files
  - new: https://git.openjdk.org/skara/pull/1502/files/23b21d54..91eee2f8

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1502&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1502&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1502.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1502/head:pull/1502

PR: https://git.openjdk.org/skara/pull/1502

More information about the skara-dev mailing list