RFR: 1873: Possible notification race with tags

Erik Joelsson erikj at openjdk.org
Mon Apr 24 22:54:25 UTC 2023

On Mon, 24 Apr 2023 21:27:47 GMT, Zhao Song <zsong at openjdk.org> wrote:

> As Erik said in the issue description, "If a new commit is integrated into a repository branch and quickly tagged, the notifier may miss updating the "Resolved In Build" field in the issue associated with that commit. This happens if the same RepositoryWorkItem instance handles both the tag and the commit, because it will handle the tag first, before a suitable backport has been created".
> To solve this issue, we need to rearrange the order of handles of the tags and commits. 
> I checked the logic in the two methods(**handleTags** and **handleRef**) and I couldn't find any problem would be introduced due to this change. But I could not guarantee that no problem would be found later.

Marked as reviewed by erikj (Lead).


PR Review: https://git.openjdk.org/skara/pull/1507#pullrequestreview-1398904393

More information about the skara-dev mailing list