Integrated: 1873: Possible notification race with tags

Zhao Song zsong at
Wed Apr 26 15:39:53 UTC 2023

On Mon, 24 Apr 2023 21:27:47 GMT, Zhao Song <zsong at> wrote:

> As Erik said in the issue description, "If a new commit is integrated into a repository branch and quickly tagged, the notifier may miss updating the "Resolved In Build" field in the issue associated with that commit. This happens if the same RepositoryWorkItem instance handles both the tag and the commit, because it will handle the tag first, before a suitable backport has been created".
> To solve this issue, we need to rearrange the order of handles of the tags and commits. 
> I checked the logic in the two methods(**handleTags** and **handleRef**) and I couldn't find any problem would be introduced due to this change. But I could not guarantee that no problem would be found later.

This pull request has now been integrated.

Changeset: e51b2df0
Author:    Zhao Song <zsong at>
Stats:     85 lines in 2 files changed: 79 ins; 4 del; 2 mod

1873: Possible notification race with tags

Reviewed-by: erikj



More information about the skara-dev mailing list