RFR: 1860: Make it possible to configure PR bot to jcheck all commits in "Merge PR" [v2]
Zhao Song
zsong at openjdk.org
Wed Apr 26 22:29:58 UTC 2023
On Wed, 26 Apr 2023 22:02:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
>>
>> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1162:
>
>> 1160: .map(StringBuilder::toString)
>> 1161: .toList());
>> 1162: } catch (Exception e) {
>
> I think instead of catching Exception here, let the outer try-catch take it as that will trigger a retry and a suitable message to be printed.
Ah, right. And I will also remove the try catch when running "second jcheck".
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1510#discussion_r1178455002
More information about the skara-dev
mailing list