RFR: 1860: Make it possible to configure PR bot to jcheck all commits in "Merge PR" [v2]

Erik Joelsson erikj at openjdk.org
Wed Apr 26 22:42:37 UTC 2023

On Wed, 26 Apr 2023 22:27:44 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1162:
>>> 1160:                                     .map(StringBuilder::toString)
>>> 1161:                                     .toList());
>>> 1162:                         } catch (Exception e) {
>> I think instead of catching Exception here, let the outer try-catch take it as that will trigger a retry and a suitable message to be printed.
> Ah, right. And I will also remove the try catch when running "second jcheck".

Good, do that please. 

For the second jcheck, there may be a usecase for printing the exception, because the user has made edits to .jcheck/conf. On the other hand, I don't think we should ever print `e.getMessage()` on a caught `Exception` instance to the user unless we know exactly what would have thrown it. It's enough that it gets logged for now. If jcheck throws exceptions that the user needs to see, then we need to fix jcheck to present that as a valid failure instead.


PR Review Comment: https://git.openjdk.org/skara/pull/1510#discussion_r1178461797

More information about the skara-dev mailing list