RFR: 2004: Field 'groups' in Class GitLabHost should be 'List' [v2]

Erik Joelsson erikj at openjdk.org
Thu Aug 24 17:26:22 UTC 2023

On Thu, 24 Aug 2023 17:21:32 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, the type of field 'groups' in GitLabHost is a set. However, we would like the bot has some preference for some groups, so this field should be able to keep the order. 
>> The solution is to change the type this field to List.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   update

Marked as reviewed by erikj (Lead).

forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java line 53:

> 51:             name = configuration.get("name").asString();
> 52:         }
> 53:         List<String> groups = new ArrayList<>();

I would suggest using `List.of()` since we aren't updating this list.


PR Review: https://git.openjdk.org/skara/pull/1550#pullrequestreview-1594097323
PR Review Comment: https://git.openjdk.org/skara/pull/1550#discussion_r1304641453

More information about the skara-dev mailing list