RFR: 2004: Field 'groups' in Class GitLabHost should be 'List' [v2]

[Zhao Song]

On Thu, 24 Aug 2023 17:17:33 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java line 53:
> 
>> 51:             name = configuration.get("name").asString();
>> 52:         }
>> 53:         List<String> groups = new ArrayList<>();
> 
> I would suggest using `List.of()` since we aren't updating this list.

Sure. It's better.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1550#discussion_r1304645549