RFR: 2115: More flexible merge PR review configuration

[Erik Joelsson]

On Wed, 6 Dec 2023 10:35:18 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that enables a bit more flexible configuration for checking merge pull requests. Today we can configure that a merge pull requests always should be checked and if that isn't configured then the `.jcheck/conf` from the repository is used. If we ever want to set `merge=check` in the `.jcheck/conf` file in repos then we will need a way to _disable_ running jcheck on merge pull requests (for example for projects using merge pull requests to sync in commits).
> 
> This patch makes it possible to configure that merge pull requests should either always be checked, never be checked or checked according to `.jcheck/conf` in the repo.
> 
> Thanks,
> Erik

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 370:

> 368:     }
> 369: 
> 370:     public MergePullRequestReviewConfiguration reviewMerge(){

Suggestion:

    public MergePullRequestReviewConfiguration reviewMerge() {

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 215:

> 213:                 } else if (val.equals("never")) {
> 214:                     result = MergePullRequestReviewConfiguration.NEVER;
> 215:                 }

We should throw on an invalid configuration.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1592#discussion_r1417863855
PR Review Comment: https://git.openjdk.org/skara/pull/1592#discussion_r1417865343