RFR: 2115: More flexible merge PR review configuration [v2]

[Erik Duveblad]

On Wed, 6 Dec 2023 19:09:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Erik Duveblad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 370:
> 
>> 368:     }
>> 369: 
>> 370:     public MergePullRequestReviewConfiguration reviewMerge(){
> 
> Suggestion:
> 
>     public MergePullRequestReviewConfiguration reviewMerge() {

Thanks, fixed in `HEAD`

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 215:
> 
>> 213:                 } else if (val.equals("never")) {
>> 214:                     result = MergePullRequestReviewConfiguration.NEVER;
>> 215:                 }
> 
> We should throw on an invalid configuration.

Agree, fixed in latest commit.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1592#discussion_r1426690947
PR Review Comment: https://git.openjdk.org/skara/pull/1592#discussion_r1426691178